Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clang/test/Interpreter/const.cpp fails on Windows #68092

Open
hahnjo opened this issue Oct 3, 2023 · 3 comments
Open

clang/test/Interpreter/const.cpp fails on Windows #68092

hahnjo opened this issue Oct 3, 2023 · 3 comments
Labels
orcjit platform:windows

Comments

@hahnjo
Copy link
Member

hahnjo commented Oct 3, 2023

added in 05137ec / #65257

Is it because the JIT doesn't support de-duplication on Windows? @lhames
@hahnjo hahnjo added the orcjit label Oct 3, 2023
@llvmbot
Copy link
Collaborator

llvmbot commented Oct 3, 2023

@llvm/issue-subscribers-orcjit

added in https://github.com/llvm/llvm-project/commit/05137ecfca0bd2f7fa6cd30c771dfacbb8188785 / https://github.com//pull/65257

Is it because the JIT doesn't support de-duplication on Windows? @lhames

hahnjo referenced this issue Oct 3, 2023
@hahnjo
[clang-repl] Emit const variables only once (#65257)
05137ec 
Disable internal linkage for const variables if IncrementalExtensions
are enabled. Otherwise the variables are emitted multiple times, with
multiple constructions at unique memory locations, during every PTU.
@hahnjo hahnjo mentioned this issue Oct 3, 2023
Merged
@vgvassilev
Copy link
Contributor

Perhaps @sunho could also help here?

@hahnjo hahnjo mentioned this issue Nov 1, 2023
Merged
@mstorsjo
Copy link
Member

mstorsjo commented Nov 2, 2023

For the record, as observed in #70991, this is only an issue with MSVC mode targets, mingw mode targets run just fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
orcjit platform:windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mstorsjo @hahnjo @vgvassilev @EugeneZelenko @llvmbot