Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notifications] notifications do not trigger until workflows are run #68748

Open
eric-k256 opened this issue Oct 10, 2023 · 1 comment
Open
Labels
infrastructure Bugs about LLVM infrastructure

Comments

@eric-k256
Copy link
Contributor

When PRs from new submitters are created, the pr-subscribers-* notification comment is not created until someone with write permissions approves the GitHub workflow to run.

I don't know if there is a way around this using workflows, but it leads to a situation where no one knows to run the workflow because the subscribers haven't been tagged/notified.

See #68509 as an example, with the PR 10 hours ago, and no comment until just now when I clicked the 'Approve and Run' button in the GitHub UI.

@eric-k256 eric-k256 added the infrastructure Bugs about LLVM infrastructure label Oct 10, 2023
@llvmbot
Copy link
Collaborator

llvmbot commented Oct 10, 2023

@llvm/issue-subscribers-infrastructure

Author: Eric Kunze (eric-k256)

When PRs from new submitters are created, the pr-subscribers-* notification comment is not created until someone with write permissions approves the GitHub workflow to run.

I don't know if there is a way around this using workflows, but it leads to a situation where no one knows to run the workflow because the subscribers haven't been tagged/notified.

See #68509 as an example, with the PR 10 hours ago, and no comment until just now when I clicked the 'Approve and Run' button in the GitHub UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Bugs about LLVM infrastructure
Projects
Status: No status
Development

No branches or pull requests

2 participants