Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LLVM 17][libc++] Cherry-pick ABI tag fix from #69669 #70329

Closed
ldionne opened this issue Oct 26, 2023 · 2 comments · Fixed by llvm/llvm-project-release-prs#750
Closed

[LLVM 17][libc++] Cherry-pick ABI tag fix from #69669 #70329

ldionne opened this issue Oct 26, 2023 · 2 comments · Fixed by llvm/llvm-project-release-prs#750
Assignees
@ldionne
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. release:backport
Milestone
LLVM 17.0.X Release

Comments

@ldionne
Copy link
Member

ldionne commented Oct 26, 2023

PR #69669 fixed a pretty important case of possible ODR violations, and I think that's something we want to fix in LLVM 17 if we can. I am working on a custom PR to backport that change to the release.

Just to clarify, this doesn't break the ABI. It removes the possibility of ODR violations in some cases that we previously handled incorrectly (for example mixing -fno-exceptions with -fexceptions in different TUs).
@ldionne ldionne added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Oct 26, 2023
@ldionne ldionne added this to the LLVM 17.0.X Release milestone Oct 26, 2023
@ldionne ldionne self-assigned this Oct 26, 2023
@ldionne
Copy link
Member Author

ldionne commented Oct 26, 2023

/branch ldionne/llvm-project/review/cherry-pick-ABI-fix-17

@llvmbot llvmbot mentioned this issue Oct 26, 2023
Merged
@llvmbot
Copy link
Collaborator

llvmbot commented Oct 26, 2023

/pull-request llvm/llvm-project-release-prs#750

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ldionne ldionne

Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. release:backport
Projects
LLVM Release Status
Status: Done
Milestone
LLVM 17.0.X Release
Development

Successfully merging a pull request may close this issue.

PR for llvm/llvm-project#70329 llvm/llvm-project-release-prs
3 participants
@ldionne @EugeneZelenko @llvmbot