Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLVM 18.1.0 release have rc suffix #84168

Closed
SuperSodaSea opened this issue Mar 6, 2024 · 8 comments
Closed

LLVM 18.1.0 release have rc suffix #84168

SuperSodaSea opened this issue Mar 6, 2024 · 8 comments
Labels
cmake Build system in general and CMake in particular

Comments

@SuperSodaSea
Copy link
Contributor

SuperSodaSea commented Mar 6, 2024

It seems that the LLVM 18.1.0 release still have an rc suffix:

if(NOT DEFINED LLVM_VERSION_SUFFIX)
set(LLVM_VERSION_SUFFIX rc)
endif()

The rc suffix will show up in the version info:

$ clang -v
clang version 18.1.0rc

It also shows up in the documentation:

https://releases.llvm.org/18.1.0/tools/clang/docs/ReleaseNotes.html

Clang 18.1.0rc documentation

Is this intentional or a mistake?

@dtcxzyw
Copy link
Member

dtcxzyw commented Mar 6, 2024

cc @tstellar

@Endilll
Copy link
Contributor

Endilll commented Mar 6, 2024

Is this intentional or a mistake?

IIRC 17.0.0 had the same issue, and was quickly followed by 17.0.1.

@EugeneZelenko EugeneZelenko added cmake Build system in general and CMake in particular and removed new issue labels Mar 6, 2024
@EugeneZelenko EugeneZelenko added this to the LLVM 18.X Release milestone Mar 6, 2024
@tstellar
Copy link
Collaborator

tstellar commented Mar 6, 2024

Sorry I missed this. I'm still deciding whether to do an immediate 18.1.1 or wait two weeks as currently planned.

@Endilll
Copy link
Contributor

Endilll commented Mar 6, 2024

@tstellar In case it's important for your decision, Clang 18 seems to have a serious CodeGen regression: #84178

@debohman
Copy link

debohman commented Mar 6, 2024

I noticed this, too. I caught it while cmake was running, so I just fixed the llvm/CMakeLists.txt and then reran cmake from scratch. It is building now.

@finagolfin
Copy link

I am seeing this in the upcoming Termux release too, termux/termux-packages#19399, which runs natively on Android devices.

> clang --version
clang version 18.1.0rc
Target: aarch64-unknown-linux-android24
Thread model: posix
InstalledDir: /data/data/com.termux/files/usr/bin
> ls -l /data/data/com.termux/files/usr/lib/libLLVM*so*
lrwxrwxrwx 1 u0_a318 u0_a318        22 Mar  7 08:03 /data/data/com.termux/files/usr/lib/libLLVM-18rc.so -> libLLVM.so.18.1rc
-rw------- 1 u0_a318 u0_a318 114521088 Mar  6 21:27 /data/data/com.termux/files/usr/lib/libLLVM.so

@MehdiChinoune
Copy link
Contributor

A simple workaround is to pass -DLLVM_VERSION_SUFFIX="" to cmake.

@andypost
Copy link

andypost commented Mar 8, 2024

It was fixed via b92012c in 18.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmake Build system in general and CMake in particular
Projects
Development

No branches or pull requests

9 participants