llvm-ranlib crashes on empty files

[lattner]

Bugzilla Link	506
Resolution	FIXED
Resolved on	Mar 06, 2010 14:05
Version	1.4
OS	All

Extended Description

$ touch xxx.a
$ llvm-ranlib xxx.a
llvm-ranlib: llvm-ranlib.cpp:72: int main(int, char**): Assertion `TheArchive &&
"Unable to instantiate the archive"' failed.
llvm-ranlib((anonymous namespace)::PrintStackTrace()+0x1a)[0x829784e]
llvm-ranlib((anonymous namespace)::SignalHandler(int)+0xc7)[0x8297abb]
/lib/tls/libc.so.6[0x2baa58]
/lib/tls/libc.so.6(abort+0x1d2)[0x2bc342]
/lib/tls/libc.so.6(__assert_fail+0x108)[0x2b4338]
llvm-ranlib(main+0x1db)[0x81968c7]
/lib/tls/libc.so.6(__libc_start_main+0xf0)[0x2a8770]
llvm-ranlib(std::__throw_logic_error(char const*)+0x49)[0x8196431]
Abort

[llvmbot]

Fixed.
The main program wasn't handling a null return from Archive::OpenAndLoad which
originally was gauranteed to not return null and only throw on error but an
interface change wasn't propagated to llvm-ranlib.

Patch here:
http://mail.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20050207/024056.html