llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.cpp:113: Possible bad expression ?

[dcb314]

Static analyser cppcheck says:

llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.cpp:113:38: style: Same expression on both sides of '||'. [duplicateExpression]

Source code is

if (!AMDGPU::isGraphics(CC) ||
((CC == CallingConv::AMDGPU_CS || CC == CallingConv::AMDGPU_CS) &&
ST.hasArchitectedSGPRs())) {

Suggest code rework.

[llvmbot]

@llvm/issue-subscribers-backend-amdgpu

Author: None (dcb314)

Static analyser cppcheck says:

llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.cpp:113:38: style: Same expression on both sides of '||'. [duplicateExpression]

Source code is

if (!AMDGPU::isGraphics(CC) ||
((CC == CallingConv::AMDGPU_CS || CC == CallingConv::AMDGPU_CS) &&
ST.hasArchitectedSGPRs())) {

Suggest code rework.

[arsenm]

I think this is also missing the AMDGPU_CS_Chain and AMDGPU_CS_ChainPreserved cases