Skip to content
This repository has been archived by the owner on Jul 3, 2020. It is now read-only.

"remove" or "relax" limit imposed by using std::array #16

Open
3 tasks
llyr-who opened this issue Jun 12, 2020 · 0 comments
Open
3 tasks

"remove" or "relax" limit imposed by using std::array #16

llyr-who opened this issue Jun 12, 2020 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@llyr-who
Copy link
Owner

llyr-who commented Jun 12, 2020

Problem

std::array is quite limited, in terms of size. On my machine (relative high end XPS), anything beyond a 500x500 matrix causes a seg fault. I think this is because we went beyond what is allowed on the stack. Can we split it up? Can we do something smart? Or shall we resort to a raw memory? (vectors are bad, we are already wrapping them so we can provide some safety)

Suggested Solution

One SS could be to split this up into matrix and tiny_matrix. tiny_matrix will continue to use std::array<T,N>'s and matrix would use T*. Note that we can use std array instead of C-style array because std::array is identical in performance and nicer to use. So use it.

Acceptance Criteria.

  • Careful well-reasoned/justified implementation
  • testing
  • benchmarking
@llyr-who llyr-who added the bug Something isn't working label Jun 12, 2020
@llyr-who llyr-who self-assigned this Jun 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant