Fixes Exception when infected process closes #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update will catch the exception and then add [Terminated] to the process title in the info_view
| for open_file in self.process.get_open_files(): | ||
| files.append(open_file.path) | ||
| open_files = files | ||
| time.sleep(1) |
There was a problem hiding this comment.
It goes into a tight loop otherwise. Alternatively we can kill the thread
and start a new one when the user selects a new process
-Jlew
Sent from android
On Mar 15, 2012 1:28 PM, "Luke Macken" <
reply@reply.github.com>
wrote:
else:
rip, rport = conn.remote_addressconnections.append({'type': type,'status': conn.status,'local': '%s:%s' % (lip, lport),'remote': '%s:%s' % (rip, rport),})- open_connections = connections
# Open filesfiles = []for open_file in self.process.get_open_files():files.append(open_file.path)open_files = filestime.sleep(1)Is this sleep necessary?
Reply to this email directly or view it on GitHub:
https://github.com/lmacken/pyrasite-gui/pull/1/files#r564215
lmacken
added a commit
that referenced
this pull request
Mar 15, 2012
Fixes Exception when infected process closes
|
Looks good to me, thanks jlew! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to reproduce this bug.
In one terminal start a python process
Open pyrasite-gui
Infect that process
Close the terminal (or kill the python process)
Result: Exception to console, update thread crashes an no longer updates any processes.