Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How could we add HMR to this project? #13

Open
jflayhart opened this issue Sep 20, 2017 · 1 comment
Open

How could we add HMR to this project? #13

jflayhart opened this issue Sep 20, 2017 · 1 comment

Comments

@jflayhart
Copy link

I realize nodemon is used to conveniently rebuild after code changes, but then of course we still have to manually refresh the page. Do we have any plan to emulate HMR? I'd be happy to look into it as well, but honestly I am not well versed Webpack 2/3. Thanks for the demo!
@jflayhart jflayhart changed the title How can we add HMR to this project? How could we add HMR to this project? Sep 20, 2017
@jflayhart
Copy link
Author

One thought I had is we could use webpack's dev server when NODE_ENV=development and universal rendering is disabled. This way we take advantage of Webpack's built in dev server with HMR. Then when universal is turned on and/or if ENV is production, then we use node server which does not support HMR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jflayhart