Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in depth2normal.cu #7

Closed
pengwangucla opened this issue Jun 9, 2017 · 1 comment
Closed

Bug in depth2normal.cu #7

pengwangucla opened this issue Jun 9, 2017 · 1 comment

Comments

@pengwangucla
Copy link

HI Benjamin,

Bug in your depth2normal code ? I recently use your depth2normal code and find the tensorflow implementation.

    const T cx = 1/(intrinsics[4*z+2]*x_size);
    const T cy = 1/(intrinsics[4*z+3]*y_size);

you have cx, cy as inverse of the input. I think it might be a bug since when we compute cx, cy, we do not need to inverse it.

@benjaminum
Copy link
Collaborator

moved to lmb-freiburg/lmbspecialops#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants