New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a seed parameter for repeatability #14
Comments
I agree, that would make a lot of sense. Ideally it isn't too hard, but has some quirks given how I am currently handling random number generation. It is certainly on my list of things to do (which is unfortunately long). |
It might be a good idea to publish a roadmap, community will be able to contribute! |
Sounds like a good plan -- any suggestions for where and how best to do that? |
Well, an issue on github will do. People will add comments, and you will be able to update the issue after each release. |
Basic random seed support is now in place via the Edit: and it doesn't actually achieve the desired result :-( Not sure why though. It should provide slightly more consistency though. |
Okay, that helps more. I have a nagging feeling there will be more minor things like the eigenvector solver to track down if I want to truly eliminate variability. |
Well that was a lot more work than I intended. For the record (since others may face this, and so I will remember in the future) the issue is that numba very cleverly swaps out np.random calls for something lower level (to avoid roundtrips back to python I presume), and this does (may?) not play nice with setting a random seed for numpy. Once I worked out what the issue was and rewrote everything to deal with that the issue resolved itself nicely and we get something repeatable. I believe setting |
It would be great to add seed parameter for repeatability, the way how scikit-learn does it.
The text was updated successfully, but these errors were encountered: