Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI | Only show delete when text in searchbar #261

Closed
lmcjt37 opened this issue Oct 18, 2021 · 5 comments
Closed

UI | Only show delete when text in searchbar #261

lmcjt37 opened this issue Oct 18, 2021 · 5 comments

Comments

@lmcjt37
Copy link
Owner

lmcjt37 commented Oct 18, 2021

If there is no text in the search bar then the 'close' icon should be hidden.

When something is typed into the searchbar then we should show the 'close' icon.

@pratik9333
Copy link
Contributor

Can I do it @lmcjt37

@lmcjt37
Copy link
Owner Author

lmcjt37 commented Oct 18, 2021

@pratik9333 yep 👍 assigned

@pratik9333
Copy link
Contributor

Hey, I have solved the issue and creating pull req :)

@pratik9333
Copy link
Contributor

Thanks for assigning, loved to worked on it and one tip you can use Context API for state management rather than prop drilling. NVM thanks @lmcjt37

@lmcjt37
Copy link
Owner Author

lmcjt37 commented Oct 20, 2021

@pratik9333 closing now issue is fixed. Thanks for all your work and working through the reviews for me.

Thanks for assigning, loved to worked on it and one tip you can use Context API for state management rather than prop drilling.

When the repo was started the context API didn't exist. I will raise a ticket for someone to pick this up though.

@lmcjt37 lmcjt37 closed this as completed Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants