Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vote: Release 0.0.4 #27

Closed
benalexau opened this issue Sep 7, 2016 · 4 comments
Closed

Vote: Release 0.0.4 #27

benalexau opened this issue Sep 7, 2016 · 4 comments

Comments

@benalexau
Copy link
Member

Seems about time we made a new release given the issues resolved since 0.0.3 on 12 August (bugs: #18, #25; usability improvements: #21, #23, #26).

@krisskross and @phraktle, any thoughts on this (eg do we want to finalise the byte[] work in PR #22 first)?

@phraktle
Copy link
Contributor

phraktle commented Sep 7, 2016

Before a release, I would suggest reviewing validations that are now potentially made redundant by the fix to Exception handling, which LMDB does yield a proper return code for.

I wouldn't close #3 quite yet (without working through the performance aspects), but I haven't had time to review. I suppose if there are no regressions in Dbi<ByteBuffer>, there's no harm in releasing preliminary Dbi<byte[]> support.

@krisskross
Copy link
Contributor

We can leave #3 for later. To be honest, I forgot about the PR. Will check ASAP. Go ahead with the release.

@benalexau
Copy link
Member Author

@phraktle I reverted part of commits made for issues #21 and #26. The C side is now being relied upon for the error creation. I left #23 in place given our separate continuing conversations re Txn ThreadLocal use.

I'll make a release in a few days, just to give a chance for us to determine what should happen with #23's guard.

@benalexau
Copy link
Member Author

0.0.4 release completed.

Travis log: https://travis-ci.org/lmdbjava/lmdbjava/jobs/159506341

0.0.4 will be available from Maven Central after their indexing / replication is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants