Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete on non-exsistent keys should return boolean instead of throwing exception #44

Closed
phraktle opened this issue Jan 23, 2017 · 0 comments
Closed

delete on non-exsistent keys should return boolean instead of throwing exception #44

phraktle opened this issue Jan 23, 2017 · 0 comments

Comments

@phraktle
Copy link
Contributor

Similar to #39, Dbi#delete should use a return a boolean indicating success, rather than throwing KeyNotFoundException when the key is not found. This is more in line with Java conventions and also more performant in case of misses.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@phraktle