Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential for Angular errors regarding already running a $digest #2

Closed
rmarsch opened this issue Oct 2, 2013 · 1 comment
Closed

Potential for Angular errors regarding already running a $digest #2

rmarsch opened this issue Oct 2, 2013 · 1 comment

Comments

@rmarsch
Copy link

rmarsch commented Oct 2, 2013

The usage of rootScope.$apply() is not guarded by a conditional check if(!rootScope.$$phase)

The result is that scenarios may occur where Angular will throw an error that a $digest is already running when the rootScope.$apply is called.
@lmirosevic
Copy link
Owner

Fixed: a10c2c6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lmirosevic @rmarsch