Skip to content
This repository has been archived by the owner on Nov 6, 2021. It is now read-only.

[BUG] #83

Closed
1 task
DuskEcho opened this issue Nov 22, 2019 · 2 comments
Closed
1 task

[BUG] #83

DuskEcho opened this issue Nov 22, 2019 · 2 comments
Assignees

Comments

@DuskEcho
Copy link

Please describe the problem you are having in as much detail as possible:

getting: "EshopError: Fetching of US Games failed" on calling
getGamesUS();
and
getGamesUS({shop: 'unfiltered'});

{ EshopError: Fetching of US Games failed
at new e (...\node_modules\nintendo-switch-eshop\dist\index.js:1:156866)
at ...\node_modules\nintendo-switch-eshop\dist\index.js:1:160490
at ...\node_modules\nintendo-switch-eshop\dist\index.js:1:2156
at Object.throw (...\node_modules\nintendo-switch-eshop\dist\index.js:1:2261)
at o (...\node_modules\nintendo-switch-eshop\dist\index.js:1:1070)
at process._tickCallback (internal/process/next_tick.js:68:7) name: 'EshopError' }

getGamesEurope() seems unaffected.

Include a reproducible code sample here, if possible:

module.exports = {
    setAllGames: async () => {
        console.log("searching getGamesAmerica");
        allGames = await getGamesAmerica({shop: 'unfiltered'});
        console.log("Total games: " + allGames.length);
    },
}
// Place your code here

Further details:

  • version: 2.2.4
  • Node.js version: 10.16.3
  • Operating system: Windows 10 - 64 bit
  • Priority this issue should have – please be realistic and elaborate if possible: Fairly high if getGamesUS is actually broken, fairly low if user error
  • I have also tested the issue on latest master, commit hash:
@favna favna self-assigned this Nov 22, 2019
@favna
Copy link
Collaborator

favna commented Nov 22, 2019

Looks like Nintendo changed the limit from 1K games per request to 100 games per request. Fixed in master (83d8934) now, just waiting for all the CI to pass before I publish.

@favna
Copy link
Collaborator

favna commented Nov 22, 2019

published v2.2.5 with the fixes to NPM

@favna favna closed this as completed Nov 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants