-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Follow" buttons on main page #12
Comments
It will also be quite redundant with our community tab, so we can consider making an include w/ a switch to change style as well? |
I agree on that you can hide those buttons if you want. |
I suggest removing the links from the community dropdown. I also think they're evil, a regular menu item (assumingly part of the sitemap) should not link to external sites. I was surprised by that a lot when I first clicked it.
I vote for plain, color makes them more important than they really are ;)
As long as we have enough content to fill such a giant footer, I'm not opposed to the idea. |
That is cool! How do the numbers get updated? |
Well I used mdo's Github buttons and Facebook's official like button, so they get updated whenever there's a new like or star. I would have put a count to the G+ button too, but its too wide compared to the others when I do so. |
Hmmmm... Yeah we use thier API with credentials as to not exceed the daily If I'm reading it correctly, his solution uses JavaScript to read the JSON Our approach uses PHP to read cached JSON data from the local web server So if my assumptions are correct, his solution could break quickly on a Furthermore, we have those bootstrap styles already in bootstrap.min.js so I haven't ported any of the existing JSON feeds to to JS yet, and we make Currently the feed updates block the page load so I've removed them from |
So short answer, if we do this let's roll our own. :) |
Please don't ever use facebook's like button on our official website! There are major privacy issues with it (it violates privacy laws in Germany and Canada for instance). Here are some links about it.
As the mdo's buttons use Javascript, the queries are sent from each visitor's browser/computer, so this wouldn't break anything for users except for those who visit our sites a hundred times per second, correct? Nevertheless, I have been playing around with this as well a week ago. But because of the facebook privacy issues and because I didn't like the So I agree, if we're going to make buttons, we should make our own ;) |
On Aug 16, 2014 1:02 PM, "Lukas W" notifications@github.com wrote:
Thx for the info.
Ah good point. In my testing 10 in a minute can trigger this (all services |
If 10 in a minute are enough to reach the limit we should indeed roll our own. ;) |
You guys have really valid points. I never knew that about the facebook button. Interesting. |
Opinions wanted for follow buttons on the home page.
I personally hate them because they just put a bunch of buttons people rarely click on right in the middle of our home page (or in the case of the Digg example below, at the bottom of the page) however some services such as Google+ will only allow the pages to have a verified URL if we link them on our home page (they then crawl our home page for a link).
My proposal is to put one in the footer that's
style="display:none;"
so we can get the verification without the interface bloat but maybe people actually use them and I'm a bit old school?Please share your opinion. 😈
The text was updated successfully, but these errors were encountered: