Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link out for GO, Pfam, and EnsemblBacteria in Systems table #10

Closed
kdahlquist opened this issue Aug 28, 2015 · 10 comments
Closed

Fix link out for GO, Pfam, and EnsemblBacteria in Systems table #10

kdahlquist opened this issue Aug 28, 2015 · 10 comments

Comments

@kdahlquist
Copy link
Contributor

I'm testing the Backpage links for the Vibrio export. The link for GO is going to the wrong page, stay tuned for how to fix it.

@kdahlquist kdahlquist self-assigned this Aug 28, 2015
@kdahlquist kdahlquist changed the title Fix link out for GO in Systems table Fix link out for GO, Pfam, and EnsemblBacteria in Systems table Aug 28, 2015
@kdahlquist
Copy link
Contributor Author

Pfam and EnsemblBacteria also have issues, stay tuned for how to fix it.

@kdahlquist
Copy link
Contributor Author

If I were to push a fix to this directly to GitHub, where would I put it? Which branch? Where is this file anyway in the code? I think for the sake of expediency, I will need to tell @dondi the changes and have you make them.

@kdahlquist
Copy link
Contributor Author

For GO terms, the new Link out should be:

http://amigo.geneontology.org/amigo/term/GO:~

For example: http://amigo.geneontology.org/amigo/term/GO:0061621

In our gdb, the "GO:" has been stripped out of the ID column, so I'm thinking that the tilde has to go after the ":", right?

@kdahlquist
Copy link
Contributor Author

For Pfam the new link out should be:

http://pfam.xfam.org/family/~

For example: http://pfam.xfam.org/family/PF00587

@kdahlquist
Copy link
Contributor Author

For EnsemblBacteria, the new link out should be:

http://bacteria.ensembl.org/Multi/Search/Results?species=all;idx=;q=~;site=ensemblunit

For example: http://bacteria.ensembl.org/Multi/Search/Results?species=all;idx=;q=AAF96469;site=ensemblunit

We should also change the link out for OrderedLocusNames for Vibrio to this EnsemblBacteria on. The TIGR CMR is no longer actually online that I can tell.

I'm reassigning this to @dondi .

@dondi
Copy link
Contributor

dondi commented Oct 26, 2015

Sounds great, I will add/modify these link-outs tonight, and release a new build-5 after that.

Just to answer the earlier question, the changes can be submitted (though not tested) by editing this file directly:

https://github.com/lmu-bioinformatics/xmlpipedb/blob/access-64-bit/gmbuilder/src/edu/lmu/xmlpipedb/gmbuilder/databasetoolkit/profiles/VibrioCholeraeUniprotSpeciesProfile.java

The branch where all of this work is currently happening is access-64-bit. (as you know it has grown in scope quite a bit from just 64-bit, but the name has stuck so far)

@dondi
Copy link
Contributor

dondi commented Oct 26, 2015

Follow-up question...are these linkout changes universal, or specific to V. cholerae? If they are universal, they would go in the database template file. If they are specific, they would go in the Java species profile.

(upon inspection they look universal, except for OrderedLocusNames)

@kdahlquist
Copy link
Contributor Author

You answered your own question. They are universal and need to go into the database template file. The link for OrderedLocusNames fro Vibrio needs to be changed in the profile.

@dondi
Copy link
Contributor

dondi commented Oct 27, 2015

OK, this has been changed. I did an export, loaded the result into GenMAPP, then did a quick back page lookup. The links worked.

@dondi
Copy link
Contributor

dondi commented Nov 2, 2015

Merged into master with pull request #17.

@dondi dondi closed this as completed Nov 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants