Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't Multiply Sat Price by 100 for NIP-5 Verification #1338

Merged
merged 4 commits into from Jan 10, 2023

Conversation

joelklabo
Copy link
Contributor

The price in sats is being multiplied by 100, should only be done for fiat currencies.

I input a price of 999 sats and got an invoice for 99900:
image

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2023

Codecov Report

Merging #1338 (679b371) into main (bdf5980) will decrease coverage by 0.15%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1338      +/-   ##
==========================================
- Coverage   48.39%   48.24%   -0.16%     
==========================================
  Files         296      296              
  Lines       16768    16758      -10     
==========================================
- Hits         8115     8085      -30     
- Misses       8653     8673      +20     
Impacted Files Coverage Δ
lnbits/extensions/nostrnip5/crud.py 27.41% <0.00%> (-1.40%) ⬇️
lnbits/extensions/lnurldevice/tasks.py 50.00% <0.00%> (-12.97%) ⬇️
lnbits/extensions/livestream/views.py 48.14% <0.00%> (-11.86%) ⬇️
lnbits/extensions/lnurldevice/views.py 51.51% <0.00%> (-6.38%) ⬇️
lnbits/extensions/livestream/lnurl.py 27.45% <0.00%> (-5.25%) ⬇️
lnbits/extensions/livestream/views_api.py 33.96% <0.00%> (-4.50%) ⬇️
lnbits/extensions/lnurldevice/lnurl.py 13.76% <0.00%> (-3.50%) ⬇️
lnbits/extensions/lnurldevice/crud.py 28.57% <0.00%> (-2.54%) ⬇️
lnbits/extensions/lnurldevice/views_api.py 45.45% <0.00%> (-2.47%) ⬇️
lnbits/extensions/lnurldevice/models.py 76.47% <0.00%> (-0.81%) ⬇️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@joelklabo
Copy link
Contributor Author

@arcbtc is there a way I can run the formatting locally? And do you know how I can run the tests?

@arcbtc arcbtc merged commit a8fa4bd into lnbits:main Jan 10, 2023
@arcbtc
Copy link
Member

arcbtc commented Jan 10, 2023

Yes, npm install in the lnbits route, then make format, and thanks for the contributions as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants