Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] release / docker ci pipeline #1907

Merged
merged 10 commits into from Jan 30, 2024
Merged

[FEAT] release / docker ci pipeline #1907

merged 10 commits into from Jan 30, 2024

Conversation

dni
Copy link
Member

@dni dni commented Aug 28, 2023

the goal of this PR is to run these action on a new tag:

  • create a github release and autogenerate release notes on tagging
  • release a dockerimage on dockerhub for that tag and latest
  • can manually run docker publish on custom tag

BREAKING

in the future we will use docker pull lnbits/lnbits instead of lnbitsdocker/lnbits-legend

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b711137) 59.23% compared to head (03e704f) 59.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1907      +/-   ##
==========================================
+ Coverage   59.23%   59.24%   +0.01%     
==========================================
  Files          60       60              
  Lines        8951     8951              
==========================================
+ Hits         5302     5303       +1     
+ Misses       3649     3648       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dni dni changed the title [FEAT] docker ci pipeline [FEAT] release / docker ci pipeline Sep 11, 2023
@dni dni added this to the Release Version 0.11.0 milestone Sep 11, 2023
@dni dni marked this pull request as ready for review September 11, 2023 08:20
@dni dni changed the base branch from main to dev September 24, 2023 20:02
@dni dni marked this pull request as draft December 19, 2023 10:27
@dni dni marked this pull request as ready for review December 20, 2023 08:42
@dni dni requested a review from prusnak December 20, 2023 08:52
on:
push:
tags:
- "v[0-9]+.[0-9]+.[0-9]+"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we still planning to support tags of the form v0.11.rc0?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could consider switching to v as it is the default on github

v0.0.0
or 0.0.0

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant the rc0 at the end. The regex only supports digits.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently we don't have it in on-tag. we could add it. but i think rc could be an expection where we do it manually in the GUI

@motorina0
Copy link
Collaborator

The image on https://hub.docker.com/u/lnbits was Updated 4 moths ago.

Can we get the flow to run for this branch?

  • rebase dev
  • relax tag regex
  • create trial tag on this branch. Ex: dec-20-2023?
  • revert tag relax regex

@dni
Copy link
Member Author

dni commented Dec 20, 2023

The image on https://hub.docker.com/u/lnbits was Updated 4 moths ago.

Can we get the flow to run for this branch?

* rebase dev

* relax tag regex

* create trial tag on this branch. Ex: `dec-20-2023`?

* revert tag relax regex

i dont really think that adds much, i would just switch the docker with the 0.12.0 release

if we want we could manually run older tags via github actions GUI and push them like that.

@motorina0
Copy link
Collaborator

i dont really think that adds much, i would just switch the docker with the 0.12.0 release

if we want we could manually run older tags via github actions GUI and push them like that.

Its good to test before we merge.

@arcbtc arcbtc merged commit 43d92dd into dev Jan 30, 2024
22 checks passed
@arcbtc arcbtc deleted the release-workflow branch January 30, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants