New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] release / docker ci pipeline #1907
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1907 +/- ##
==========================================
+ Coverage 59.23% 59.24% +0.01%
==========================================
Files 60 60
Lines 8951 8951
==========================================
+ Hits 5302 5303 +1
+ Misses 3649 3648 -1 ☔ View full report in Codecov by Sentry. |
f029be9
to
4af5269
Compare
21f07d4
to
d646e50
Compare
d646e50
to
cb2739d
Compare
on: | ||
push: | ||
tags: | ||
- "v[0-9]+.[0-9]+.[0-9]+" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we still planning to support tags of the form v0.11.rc0
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could consider switching to v
as it is the default on github
v0.0.0
or 0.0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant the rc0
at the end. The regex only supports digits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
currently we don't have it in on-tag. we could add it. but i think rc could be an expection where we do it manually in the GUI
The image on https://hub.docker.com/u/lnbits was Can we get the flow to run for this branch?
|
i dont really think that adds much, i would just switch the docker with the if we want we could manually run older tags via github actions GUI and push them like that. |
Its good to test before we merge. |
Co-authored-by: Vlad Stan <stan.v.vlad@gmail.com>
the goal of this PR is to run these action on a new tag:
BREAKING
in the future we will use
docker pull lnbits/lnbits
instead oflnbitsdocker/lnbits-legend