Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LndRestWallet: catch http errors #2133

Merged
merged 1 commit into from Dec 19, 2023
Merged

Conversation

callebtc
Copy link
Collaborator

No description provided.

lnbits/wallets/lndrest.py Outdated Show resolved Hide resolved
lnbits/wallets/lndrest.py Outdated Show resolved Hide resolved
lnbits/wallets/lndrest.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failure: pyright

@dni dni changed the title LndResWallet: catch http errors LndRestWallet: catch http errors Dec 19, 2023
@dni dni force-pushed the fix/wallet_lndrest_payment_catch_errors branch from 7e643cd to 30b7a31 Compare December 19, 2023 11:01
@dni dni requested review from prusnak and dni December 19, 2023 11:02
@dni dni added this to the 0.12.0 milestone Dec 19, 2023
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (abbcfbe) 59.28% compared to head (ef62683) 59.29%.

Files Patch % Lines
lnbits/wallets/lndrest.py 77.77% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2133   +/-   ##
=======================================
  Coverage   59.28%   59.29%           
=======================================
  Files          59       59           
  Lines        8864     8871    +7     
=======================================
+ Hits         5255     5260    +5     
- Misses       3609     3611    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prusnak prusnak force-pushed the fix/wallet_lndrest_payment_catch_errors branch from 79241f2 to ef62683 Compare December 19, 2023 15:06
@prusnak
Copy link
Collaborator

prusnak commented Dec 19, 2023

Rebased and squashed

@arcbtc arcbtc merged commit 165d749 into dev Dec 19, 2023
22 checks passed
@arcbtc arcbtc deleted the fix/wallet_lndrest_payment_catch_errors branch December 19, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants