Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show installed extensions when manifest cannot be reached #2261

Merged
merged 1 commit into from Feb 12, 2024

Conversation

motorina0
Copy link
Collaborator

@motorina0 motorina0 commented Feb 12, 2024

Report from @callebtc:

I noticed a bug in the extension manager: if the internet connection doesn't work (or possibly if the github token is invalid), lnbits doesn't load up any extensions at all. there should probably be some sort of timeout in during which the extension manifest is polled and if it fails, the extensions should still be visible in the extension manager. I've noticed this because I had a firewall on that silently blocked requests from lnbits and no extensions showed up even though I had them installed.

The logic was there, but due to a bug the wrong filtering took place.

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (62dec11) 59.26% compared to head (73ce1ae) 59.26%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2261   +/-   ##
=======================================
  Coverage   59.26%   59.26%           
=======================================
  Files          60       60           
  Lines        9026     9027    +1     
=======================================
+ Hits         5349     5350    +1     
  Misses       3677     3677           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prusnak prusnak added this to the 0.12.2 milestone Feb 12, 2024
@dni dni merged commit 20e7085 into dev Feb 12, 2024
22 checks passed
@dni dni deleted the fix_extenson_list_no_manifest branch February 12, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants