Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] LNURLw not following lnurl withdraw specs #17

Open
michaelWuensch opened this issue Sep 20, 2023 · 3 comments
Open

[BUG] LNURLw not following lnurl withdraw specs #17

michaelWuensch opened this issue Sep 20, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@michaelWuensch
Copy link

michaelWuensch commented Sep 20, 2023

Describe the bug
When you create a LNURLw voucher that has a higher amount than available in the wallet and you try to withdraw it, the response is malformed. Wallets cannot read the error message if it doesn't follow the spec.

The specs can be found here:
https://github.com/lnurl/luds/blob/luds/03.md
The relevant section is step 6.

To Reproduce
Steps to reproduce the behavior:

  1. Create a wallet and fund it with 100 sats
  2. Enable LNURLw
  3. Create a voucher with 150 sats
  4. Try to withdraw it with a wallet

Expected behavior
This response is expected:
{"status": "ERROR", "reason": "Withdraw not working. Insufficient balance"}

But this response is delivered:
{"detail":"withdraw not working. Insufficient balance."}

Desktop (please complete the following information):

Additional context
Wallets cannot read this error message if it doesn't follow the spec.

@dni
Copy link
Member

dni commented Sep 21, 2023

thank you very much! i am on it now

@dni dni transferred this issue from lnbits/lnbits Sep 21, 2023
@dni
Copy link
Member

dni commented Sep 21, 2023

hey i saw calle actually should have fixed it 2 weeks ago, in version v0.1.2 here: #10.

can you test that again? or did you run latest already?

@michaelWuensch
Copy link
Author

michaelWuensch commented Sep 21, 2023

@dni
Awesome!
I tried it on the demo server ( https://legend.lnbits.com )
I just checked it and it is still v0.1.1 there. As I am not an admin I cannot change it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants