Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better input option(s) for images #27

Open
ceskyDJ opened this issue May 17, 2023 · 6 comments
Open

Better input option(s) for images #27

ceskyDJ opened this issue May 17, 2023 · 6 comments
Labels
blocked Blocked by other issue enhancement New feature or request

Comments

@ceskyDJ
Copy link
Contributor

ceskyDJ commented May 17, 2023

Is your feature request related to a problem? Please describe.
When I want to add image to the recipe, it is quiet problematic. I think this problem has 2 branches, so I divide my text into these.

Web (or external) images. When I have an image outside my Nextcloud and want it to add to the recipe, I need to get its URL (complicated for average user), when it's publicly available (web image) or upload it somewhere and copy URL (other images), which is too complicated and time consuming for most users, I think.

Nextcloud images. When the image is located on my Nextcloud, I just need to enter path from Nextcloud root. It is better but manual entering isn't very user friendly. Web version of Nextcloud Cookbook has a image selector for this.

Describe the solution you'd like
I'd like to see some option for uploading an external image using this app (just some simple file input, I think there are some many libraries for this purpose), copying its path and inserting it into the input (or better hiding these things and just displaying a preview of the uploaded image). This picker should have a way to select image from Nextcloud files.

@ceskyDJ ceskyDJ added the enhancement New feature or request label May 17, 2023
@lneugebauer
Copy link
Owner

Thank you for your suggestion. I agree that image input is kind of tricky. Handling image upload and integrating images selection from Nextcloud is kind of involved though. So I'll takle this but I'm not sure when this will be done. You will be updated via this issue about the update status.

@lneugebauer lneugebauer self-assigned this May 19, 2023
@ceskyDJ
Copy link
Contributor Author

ceskyDJ commented May 19, 2023

Thanks! Don't hurry up, I'm glad to see this project is evolving. I tried every Android app client for Nextcloud Cookbook and I find only your app good working a useful for my usage (and I think usage for many other people). There is just a few little things like this and it would be perfect!

@lneugebauer lneugebauer added the blocked Blocked by other issue label Aug 16, 2023
@lneugebauer
Copy link
Owner

There is some work to be done server side, as mentioned in #42.

@lneugebauer lneugebauer removed their assignment Aug 16, 2023
@ceskyDJ
Copy link
Contributor Author

ceskyDJ commented Aug 16, 2023

You could do it yourself using API endpoint for file management, but I see the easier (and maybe better, too) option is to use just one endpoint for everything.

@lneugebauer
Copy link
Owner

Well, I'd then also have to generate the different sizes and move them to the recipe app folder. I think using a provided API endpoint would really be more appropriate. Especially since this is quite a big feature to implement only to be changed again in the future. Also, I don't know if there is any caching going on in the background that I'd be interfering with.

@ceskyDJ
Copy link
Contributor Author

ceskyDJ commented Aug 16, 2023

I get it. So, the best option for now is to help with completing API endpoint changes on the server side. I'll see how much time I have after my state exam, and possibly try to help with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked by other issue enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants