-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fish: Don't source the Nix configuration if it already has been sourced #48
Comments
All of the Nix environment setup scripts I've seen (in the I think if we change the Fish package to source /etc/static/preinit-whatever.fish instead of in plain /etc, then nix-darwin can put the file in place and NixOS should be unaffected. Right now nix-darwin can't put the file where Fish expects because it doesn't (and shouldn't) own |
@therealpxc That makes sense to me, I think. I understand what the NixOS things in the Fish package are doing, at any rate. How do you suggest managing the tickets for this? |
I think we should make the changes we want on the Nixpkgs side on a local checkout while we work out the nix-darwin stuff, then submit the PRs for both pieces. That way the PR for Nixpkgs can say 'this makes the following achievable in nix-darwin' instead of 'we hope this will enable us to do xyz for nix-darwin'. |
@therealpxc Sounds good to me. What the fish package does looks reasonable to me. I'm assuming we don't export the _fish_nixos*_sourced variables because the idea is that we reset things anew in subshells anyway? |
The other shell modules do something similar, but how is this related to setting |
@cbarrett that's right. @LnL7 The way that PATH is set is neither by appending nor pre-pending but straight-up setting PATH, so that if the Nix configuration stuff gets sourced after other things (like Since EDITOR also gets set this way, for example, it overrides the |
And to make Nix-installed CLI programs available to snippets in |
Fixed by #50 |
(Part of the effort to kill this line of code dead.)
The text was updated successfully, but these errors were encountered: