Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OnInit method inside the metrics on return an error #33

Closed
vincenzopalazzo opened this issue Aug 23, 2021 · 1 comment · Fixed by #37
Closed

OnInit method inside the metrics on return an error #33

vincenzopalazzo opened this issue Aug 23, 2021 · 1 comment · Fixed by #37
Assignees
@vincenzopalazzo
Labels
bug Something isn't working

Comments

@vincenzopalazzo
Copy link
Member

If we have an error during the on init phase, we do not storing the data. There is some error catch that we don't need to catch.
@vincenzopalazzo vincenzopalazzo added the bug Something isn't working label Aug 23, 2021
@vincenzopalazzo vincenzopalazzo self-assigned this Aug 23, 2021
@vincenzopalazzo
Copy link
Member Author

The plugin checks the node in the list nodes, that are the node of the network, we need to use the list peers, because are the peers connected to the node. However, with this information, we have some problems right now if we need to skip some nodes that is no present anymore in the command.

@vincenzopalazzo vincenzopalazzo mentioned this issue Sep 6, 2021
Merged
vincenzopalazzo added a commit that referenced this issue Sep 7, 2021
@vincenzopalazzo
Fixes #33
fe1889d 
With this commit I'm fixing the collection data about info channel in case we have an error from the list nodes.

This is useful when the node have a channels with a node that is offline for a ling time and it is out of the gossip map.

Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
jsarenik pushed a commit to jsarenik/go-lnmetrics.reporter that referenced this issue Nov 29, 2021
@vincenzopalazzo
Fixes LNOpenMetrics#33
f6ac083 
With this commit I'm fixing the collection data about info channel in case we have an error from the list nodes.

This is useful when the node have a channels with a node that is offline for a ling time and it is out of the gossip map.

Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vincenzopalazzo vincenzopalazzo

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes onStart bug and add alias now in the metrics payload. LNOpenMetrics/go-lnmetrics.reporter
1 participant
@vincenzopalazzo