Added the dependencies to package.json #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oject only needs to run `npm install -g` from the base project directory to globally install all required dependencies for the Knwl.js project. It will also help if in the future more dependencies are added to create an easy way to manage/install them.
|
You should add node_modules to the git ignore then. |
Merged
|
This is ready to merge! Since my first one is merged in! |
|
Thanks benjojo |
benhmoore
pushed a commit
that referenced
this pull request
Dec 28, 2013
Added the dependencies to package.json
| @@ -18,6 +18,10 @@ | |||
| "engines": { | |||
| "node": "*" | |||
| }, | |||
| "dependencies": { | |||
| "jasmine-node": "*", | |||
There was a problem hiding this comment.
Whoops, I didnt notice this , but these 2 should be in devDependencies, not dependencies. Can PR requestor please change this
There was a problem hiding this comment.
totally right, please see Merge #53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now after cloning the project, they only need to run
npm install -gfrom the base project directory to globally and recursively install all required node modules (keep in mind if someone just runsnpm installthe node_modules folder will appear in the base project directory. Should consider adding a .gitignore if you do not want the node_modules folder appearing in the project).This will create an easier way for all contributors to manage/install dependencies for the project.