Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change a little bit the file structure to support multiple cultures #96

Open
mAiNiNfEcTiOn opened this issue Jun 23, 2016 · 0 comments
Open

Comments

@mAiNiNfEcTiOn
Copy link

mAiNiNfEcTiOn commented Jun 23, 2016

Hi @loadfive,

Thanks for this cool tool, I'm using it to parse some dates in English and that's quite good :)

However I want to help you to increase the translation range but the structure of the project doesn't seem to be adequate to the extensibility required for contributions.

As I see, we have a lot of translatable strings mixed with the functionality... It would be so much better to separate functionality/feature from the string searched/used. Basically making a small dictionary for the functions.

I saw you have - on the experimental_plugins - an english.js which contains some words already.

That'd be nice if you hadn't mixed some functionality (like 'findSentences' and alike).

Last but not least, consider doing a language identification based on the culture, not on the language itself. E.g:

pt_PT !== pt_BR

en_US !== en_UK

and so on.

If you want I can help out, just tell me if you'd like some help on that ;) And thanks for your time!

One thing that would be interesting to check is the possibility to integrate either with a tool/library like FormatJS or with the Unicode Group, more exactly the ICU sub-group ( http://site.icu-project.org/ ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant