Replace the external configdir library with the new os.UserConfigDir() #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1162 +/- ##
==========================================
- Coverage 73.61% 73.59% -0.03%
==========================================
Files 144 145 +1
Lines 10529 10536 +7
==========================================
+ Hits 7751 7754 +3
- Misses 2321 2323 +2
- Partials 457 459 +2
Continue to review full report at Codecov.
|
imiric
previously approved these changes
Sep 18, 2019
mstoykov
reviewed
Sep 24, 2019
mstoykov
approved these changes
Sep 24, 2019
imiric
approved these changes
Sep 24, 2019
na--
changed the title
cuonglm
added a commit
that referenced
this pull request
Sep 26, 2019
In #1162 use new os.UserConfigDir to get user config directory, and it will panic when encounter an error. This is a backward in-compatible behavior and can lead to bad UX. This PR restore previous #1162 behavior. Instead of panic, we return a default value for config dir if we can figure out user config directory. Close #1176
cuonglm
added a commit
that referenced
this pull request
Sep 26, 2019
In #1162 use new os.UserConfigDir to get user config directory, and it will panic when encounter an error. This is a backward in-compatible behavior and can lead to bad UX. This PR restore previous #1162 behavior. Instead of panic, we return a default value for config dir if we can figure out user config directory. Close #1176
cuonglm
added a commit
that referenced
this pull request
Sep 26, 2019
In #1162 use new os.UserConfigDir to get user config directory, and it will panic when encounter an error. This is a backward in-compatible behavior and can lead to bad UX. This PR restore previous #1162 behavior. Instead of panic, we return a default value for config dir if we can figure out user config directory. Close #1176
srguglielmo
pushed a commit
to srguglielmo/k6
that referenced
this pull request
Nov 3, 2019
In grafana#1162 use new os.UserConfigDir to get user config directory, and it will panic when encounter an error. This is a backward in-compatible behavior and can lead to bad UX. This PR restore previous grafana#1162 behavior. Instead of panic, we return a default value for config dir if we can figure out user config directory. Close grafana#1176
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #940, but adds a reminder to come back and clean up the Go 1.12 code when Go 1.14 comes out (#1165)