Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase http debug logging #1644

Merged

Conversation

repl-david-winiarski
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Sep 30, 2020

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2020

Codecov Report

Merging #1644 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1644      +/-   ##
==========================================
+ Coverage   72.15%   72.19%   +0.04%     
==========================================
  Files         166      166              
  Lines       12787    12793       +6     
==========================================
+ Hits         9226     9236      +10     
+ Misses       3011     3007       -4     
  Partials      550      550              
Impacted Files Coverage Δ
lib/netext/httpext/httpdebug_transport.go 75.00% <100.00%> (+5.76%) ⬆️
lib/netext/httpext/request.go 96.96% <100.00%> (+0.05%) ⬆️
lib/testutils/minirunner/minirunner.go 81.39% <0.00%> (-4.66%) ⬇️
js/runner.go 83.01% <0.00%> (+0.75%) ⬆️
lib/executor/vu_handle.go 95.23% <0.00%> (+1.90%) ⬆️
lib/executors.go 93.10% <0.00%> (+2.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f35f5c4...865996e. Read the comment docs.

@mstoykov mstoykov requested review from mstoykov, imiric and na-- and removed request for mstoykov October 1, 2020 07:41
@mstoykov
Copy link
Collaborator

mstoykov commented Oct 1, 2020

Hi @repl-david-winiarski, thanks for this PR :)
As a first thing that I notice - we do already use another uuid library github.com/nu7hatch/gouuid so it will be nice if we don't add a second one :)

@repl-david-winiarski
Copy link
Contributor Author

@mstoykov thanks for pointing that out. I've removed the additional uuid dependency and replaced it with the suggested one.

Copy link
Contributor

@imiric imiric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! 👍

@mstoykov mstoykov merged commit 4e637f6 into grafana:master Oct 16, 2020
@na-- na-- added this to the v0.29.0 milestone Oct 16, 2020
@repl-david-winiarski repl-david-winiarski deleted the IncreaseHttpDebugLogging branch October 16, 2020 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants