Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --user-agent='' making k6 to not send user agent #1695

Merged
merged 2 commits into from
Oct 29, 2020

Conversation

mstoykov
Copy link
Collaborator

No description provided.

@mstoykov mstoykov added this to the v0.29.0 milestone Oct 29, 2020
@mstoykov mstoykov requested review from imiric and na-- October 29, 2020 10:32
@codecov-io
Copy link

codecov-io commented Oct 29, 2020

Codecov Report

Merging #1695 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1695      +/-   ##
==========================================
+ Coverage   72.33%   72.37%   +0.04%     
==========================================
  Files         176      176              
  Lines       13536    13536              
==========================================
+ Hits         9791     9797       +6     
+ Misses       3132     3126       -6     
  Partials      613      613              
Flag Coverage Δ
#ubuntu 72.33% <100.00%> (+0.01%) ⬆️
#windows 70.86% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
js/modules/k6/http/request.go 80.71% <100.00%> (ø)
stats/cloud/collector.go 79.81% <0.00%> (-0.64%) ⬇️
lib/executor/ramping_arrival_rate.go 97.42% <0.00%> (+1.03%) ⬆️
core/engine.go 92.96% <0.00%> (+2.01%) ⬆️
lib/testutils/minirunner/minirunner.go 86.04% <0.00%> (+4.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf826ba...4cf263b. Read the comment docs.

@mstoykov mstoykov merged commit 7586ddf into master Oct 29, 2020
@mstoykov mstoykov deleted the fixEmptyUserAgent branch October 29, 2020 16:37
salem84 pushed a commit to salem84/k6 that referenced this pull request Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants