Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validating stages option #615

Merged
merged 2 commits into from May 9, 2018
Merged

Validating stages option #615

merged 2 commits into from May 9, 2018

Conversation

luizbafilho
Copy link
Contributor

this PR validates the stages option, making sure only valid stages are being passed down to the test.

fixes #547

Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #615 into master will decrease coverage by 0.16%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #615      +/-   ##
==========================================
- Coverage   62.23%   62.07%   -0.17%     
==========================================
  Files          97       97              
  Lines        7510     7512       +2     
==========================================
- Hits         4674     4663      -11     
- Misses       2577     2589      +12     
- Partials      259      260       +1
Impacted Files Coverage Δ
lib/options.go 95.16% <100%> (+0.07%) ⬆️
stats/units.go 50% <0%> (-50%) ⬇️
stats/stats.go 41.11% <0%> (-6.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21723fc...0ecd333. Read the comment docs.

@luizbafilho luizbafilho merged commit b62698d into master May 9, 2018
@luizbafilho luizbafilho deleted the fix/stages-validation branch May 9, 2018 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning for "no iterations could be completed" doesn't detect a specific case
3 participants