Allow stages to be properly disabled by fixing the CLI parsing #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #786 +/- ##
==========================================
- Coverage 63.93% 63.92% -0.02%
==========================================
Files 102 102
Lines 8496 8498 +2
==========================================
Hits 5432 5432
- Misses 2702 2705 +3
+ Partials 362 361 -1
Continue to review full report at Codecov.
|
robingustafsson
approved these changes
Sep 28, 2018
cmd/config_test.go
Outdated
| @@ -83,6 +83,8 @@ func TestConfigCmd(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| //TODO: write end-to-end configuration tests - how the config file, in-script options, environment variables and CLI flags are parsed and interract... and how the end result is then propagated back into the script | |||
There was a problem hiding this comment.
"interract" => "interact"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #775 - now
K6_STAGES="" k6 run script.jscan properly overwrite stages defined in the script andk6 run --stage ""can overwrite stages configured by environment variables or from the script.The
len(conf.Stages) == 0check covers both cases where stages arenil(i.e. weren't defined at all) and where they have been explicitly disabled from an upper configuration tier (empty slice).I started to do some sort of robust end-to-end configuration testing framework for the future, but I postponed it for the future and just left a TODO since we'd have to refactor how we deal with the configuration a lot to be able to end-to-end test things properly... We also need to refactor it for a bunch of other reasons, so we'd do it then anyway.