Add Hawk authentication backend #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can increase the coverage on the new code (and maybe on some of the older code, too), but I don't have the insight necessary yet to address the issues causing older versions of python to fail their tests. Is that something I could get some assistance with? |
|
Just checking to see if anyone could take a look at this. :) |
jcwilson
force-pushed
the
master
branch
18 times, most recently
from
72c2b22
to
f6a1066
Compare
jcwilson
commented
Jan 19, 2019
| @@ -5,7 +5,7 @@ | |||
| import sys | |||
| from setuptools import setup | |||
|
|
|||
| version = '1.1.0' | |||
| version = '2.0.0' | |||
There was a problem hiding this comment.
Bumping the major version as moving pyjwt to an optional dependency is a breaking change.
jcwilson
force-pushed
the
master
branch
5 times, most recently
from
3fdc2f4
to
894088b
Compare
|
This PR also contains the changes in #10, but in a way that also works for older versions of python. |
This adds support for the [Hawk "Holder-Of-Key Authentication Scheme"](https://github.com/hueniverse/hawk`) backend. This also updates the `MultiAuthBackend` to collect any challenges from failed backends and provide them on the synthesized `HTTPUnauthorized` error if no backend succeeds in authenticating the request. The hawk library, and now the jwt library, are optional dependencies that must be specified in the client project's requirements as ["extras"](https://www.python.org/dev/peps/pep-0508/#extras). This ensures that clients only install the backend libraries necessary to their use case. This also cleans up some redundant specification of default values when raising `falcon.HTTPUnauthorized` exceptions from the backend code. Lastly, it adds testing support for 3.7 and adds classifier strings to setup.py
|
@jcwilson Thanks a lot for this extensive fix. Really appreciate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the Hawk "Holder-Of-Key Authentication Scheme" backend.
This also updates the
MultiAuthBackendto collect any challenges from failedbackends and provide them on the synthesized
HTTPUnauthorizederror if nobackend succeeds in authenticating the request.
The hawk library, and now the jwt library, are optional dependencies that must be
specified in the client project's requirements as "extras". This ensures that clients
only install the backend libraries necessary to their use case.
This also cleans up some redundant specification of default values when raising
falcon.HTTPUnauthorizedexceptions from the backend code.Lastly, it adds testing support for 3.7 and adds classifier strings to
setup.py