Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heroku Node Module naming issue #52

Closed
shrav opened this issue Aug 3, 2014 · 2 comments
Closed

Heroku Node Module naming issue #52

shrav opened this issue Aug 3, 2014 · 2 comments

Comments

@shrav
Copy link
Contributor

shrav commented Aug 3, 2014

Node module will not work on Heroku. Quick fix is to require it like this:

 var Lob = require('../node_modules/lob/lib/lob');

We need to fix the naming to be all lower case!
@leore
Copy link
Contributor

leore commented Aug 3, 2014

naming of what? can you put in a PR?

@shrav
Copy link
Contributor Author

shrav commented Aug 3, 2014

I think this is something to do with NPM module. @pon may know better

@shrav shrav closed this as completed Aug 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leore @shrav