Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lob 6.0.3: Various warnings when running tests and loading library #220

Closed
broksonic21 opened this issue Oct 15, 2023 · 3 comments
Closed

Comments

@broksonic21
Copy link

Lob 6.0.2 fixed a bunch of warnings, but these appear back in Lob 6.0.3:

warning: character class has '-' without escape

#209 has more info on the original fix.

You can see the regression here, amongst other lines:
v6.0.2...v6.0.3#diff-394b2cc6b345c7ebd5c1693dcd21d403a6c17b95200e382fe646878a708ce963R260

At minimum, I am seeing it here in our app:

        DEPRECATION WARNING: /Users/REDACTED/.rbenv/versions/3.0.6/lib/ruby/gems/3.0.0/gems/lob-6.0.3/lib/openapi_client/models/thumbnail.rb:118: warning: character class has '-' without escape
   
        DEPRECATION WARNING: /Users/REDACTED/.rbenv/versions/3.0.6/lib/ruby/gems/3.0.0/gems/lob-6.0.3/lib/openapi_client/models/thumbnail.rb:129: warning: character class has '-' without escape
   
        DEPRECATION WARNING: /Users/REDACTED/.rbenv/versions/3.0.6/lib/ruby/gems/3.0.0/gems/lob-6.0.3/lib/openapi_client/models/thumbnail.rb:140: warning: character class has '-' without escape
   
        DEPRECATION WARNING: /Users/REDACTED/.rbenv/versions/3.0.6/lib/ruby/gems/3.0.0/gems/lob-6.0.3/lib/openapi_client/models/letter.rb:498: warning: character class has '-' without escape
@broksonic21
Copy link
Author

fyi @siddharthpant92 (as author of 6.0.3) and @BennyKitchell (as maintainer on 6.0.2 fix)

@siddharthpant92
Copy link
Contributor

Hey @broksonic21 Thank you for bringing this up. Hopefully his has been fixed in #221.
I can close this issue out once you confirm or if we don't hear from you soon.
Sorry for having those warnings re-surface

@broksonic21
Copy link
Author

Yep, this worked for us - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants