Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreeRTOS submodule doesn't have Linux port #34

Closed
johnathancn opened this issue Oct 11, 2022 · 3 comments · Fixed by #36
Closed

FreeRTOS submodule doesn't have Linux port #34

johnathancn opened this issue Oct 11, 2022 · 3 comments · Fixed by #36

Comments

@johnathancn
Copy link
Contributor

thread 'main' panicked at 'Directory freertos_port_dir does not exist: FreeRTOS-Kernel/portable/GCC/Linux', freertos-rust-examples/build.rs:61:38

Looks like this is recent regression following change from in-tree copy of Kernel to submodule.
I checked upstream and can't find trace of that Linux folder ever being there, maybe it was added to the local copy in this repo

@schteve
Copy link
Collaborator

schteve commented Oct 12, 2022

Thanks for catching this - the example builds don't work for me even before the submodule change so I didn't get to see this break myself. Agree the original source of the Linux port should be included.

Out of curiosity, since I see you have a proposed fix, does the Linux port build and run for you now with a simple build invocation something like this?
cargo +nightly build --example linux --target x86_64-unknown-linux-gnu

@johnathancn
Copy link
Contributor Author

Yes, with my proposed fixes, that simple build command now works. Keep in mind, the PR also includes a hack fix for the other "cpu_hz" issue I raised.

Also note, when I first raised the issue I didn't know the origin of the Linux port code, but I later found it originated from freertos-addons
so my fix involves adding that as an additional submodule.

@schteve
Copy link
Collaborator

schteve commented Oct 12, 2022

Yeah it must be something on my side then, I applied your proposed fixes but still get other errors (apparently unrelated to these issues or your fixes). I will try to sort it out, since I know the build should work I'd like to see it working on my end before merging your new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants