Fix port base for non-linux targets #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry I broke this! My mistake for only building my own use case. Looks good to me, and still working for my use case. |
johnathancn
approved these changes
Oct 27, 2022
|
Thanks! And no worries, I didn't build the other stuff either! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous changes in #36 broke the non-Linux examples since the port base path by default was not set correctly. This PR changes the mechanism to use the user-supplied value if available, otherwise fall back on the
portabledirectory inside the FreeRTOS kernel root.I confirmed that these examples work for me (with adding
#define configCPU_CLOCK_HZto avoid #35). The other have previously-existing build failures, at least on my machine.linuxstm32-cortex-m4-blackpill(build only)win@johnathancn please double check that this change still works for your use case.
We've had a bunch of accidental build breakages in the examples recently (understandably so, since users often don't have more than one platform available to test with) so I'm going to make it a priority to get a CI script running for PR's.