New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CoAP_AllocRespMsg() could return null here #40

Closed

ChrisDinhNZ opened this issue Sep 23, 2019 · 1 comment

ChrisDinhNZ commented Sep 23, 2019

If CoAP_AllocRespMsg() returns null here, do you think we can just return without calling SendResp()?

lobaro-coap/src/coap_main.c

Line 380 in 7f5fed4

    
           pIA->pRespMsg = CoAP_AllocRespMsg(pIA->pReqMsg, RESP_METHOD_NOT_ALLOWED_4_05, 0); //matches also TYPE + TOKEN to request

Member

niondir commented Sep 24, 2019

I think so, yes. It makes no sense to send out garbage. But we should ERROR log the failed malloc at least.

ChrisDinhNZ closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment