Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ› fix: hydration mismatch in grid background #171

Merged
merged 2 commits into from
Jun 25, 2024
Merged

๐Ÿ› fix: hydration mismatch in grid background #171

merged 2 commits into from
Jun 25, 2024

Conversation

phuctm97
Copy link
Contributor

๐Ÿ’ป ๅ˜ๆ›ด็ฑปๅž‹ | Change Type

  • โœจ feat
  • ๐Ÿ› fix
  • โ™ป๏ธ refactor
  • ๐Ÿ’„ style
  • ๐Ÿ”จ chore
  • ๐Ÿ“ docs

๐Ÿ”€ ๅ˜ๆ›ด่ฏดๆ˜Ž | Description of Change

There is a hydration mismatch because HighlightGrid is not pure (depends on shuffle), this fixes the problem by randomizing group in an effect.

๐Ÿ“ ่กฅๅ……ไฟกๆฏ | Additional Information

@lobehubbot
Copy link
Member

๐Ÿ‘ @phuctm97


Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
้žๅธธๆ„Ÿ่ฐขๆ‚จๆๅ‡บๆ‹‰ๅ–่ฏทๆฑ‚ๅนถไธบๆˆ‘ไปฌ็š„็คพๅŒบๅšๅ‡บ่ดก็Œฎ๏ผŒ่ฏท็กฎไฟๆ‚จๅทฒ็ป้ตๅพชไบ†ๆˆ‘ไปฌ็š„่ดก็ŒฎๆŒ‡ๅ—๏ผŒๆˆ‘ไปฌไผšๅฐฝๅฟซๅฎกๆŸฅๅฎƒใ€‚
ๅฆ‚ๆžœๆ‚จ้‡ๅˆฐไปปไฝ•้—ฎ้ข˜๏ผŒ่ฏท้šๆ—ถไธŽๆˆ‘ไปฌ่”็ณปใ€‚

@codecov Codecov
Copy link

codecov bot commented Jun 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (5851677) to head (711ca05).
Report is 68 commits behind head on master.

โ— Current head 711ca05 differs from pull request most recent head dffe429

Please upload reports for the commit dffe429 to get more accurate results.

Files Patch % Lines
src/GridBackground/index.tsx 0.00% 11 Missing โš ๏ธ
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #171    +/-   ##
=======================================
  Coverage    0.00%   0.00%            
=======================================
  Files         330     348    +18     
  Lines       22325   23306   +981     
  Branches      330     348    +18     
=======================================
- Misses      21995   22958   +963     
- Partials      330     348    +18

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@canisminor1990 canisminor1990 merged commit bbe43c4 into lobehub:master Jun 25, 2024
2 of 3 checks passed
@lobehubbot
Copy link
Member

โค๏ธ Great PR @phuctm97 โค๏ธ


The growth of project is inseparable from user feedback and contribution, thanks for your contribution!
้กน็›ฎ็š„ๆˆ้•ฟ็ฆปไธๅผ€็”จๆˆทๅ้ฆˆๅ’Œ่ดก็Œฎ๏ผŒๆ„Ÿ่ฐขๆ‚จ็š„่ดก็Œฎ!

github-actions bot pushed a commit that referenced this pull request Jun 25, 2024
@semantic-release-bot
๐Ÿ”– chore(release): v1.145.3 [skip ci]
b5d267c 
### [Version 1.145.3](v1.145.2...v1.145.3)
<sup>Released on **2024-06-25**</sup>

#### ๐Ÿ› Bug Fixes

- **misc**: Hydration mismatch in grid background.

#### ๐Ÿ’„ Styles

- **misc**: Increase gaps between ChatItem.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Hydration mismatch in grid background, closes [#171](#171) ([bbe43c4](bbe43c4))

#### Styles

* **misc**: Increase gaps between ChatItem, closes [#170](#170) ([dd487de](dd487de))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

๐ŸŽ‰ This PR is included in version 1.145.3 ๐ŸŽ‰

The release is available on:

Your semantic-release bot ๐Ÿ“ฆ๐Ÿš€

github-actions bot pushed a commit to bentwnghk/lobe-ui that referenced this pull request Jun 25, 2024
@semantic-release-bot
๐Ÿ”– chore(release): v1.17.0 [skip ci]
d3dc103 
## [Version&nbsp;1.17.0](v1.16.2...v1.17.0)
<sup>Released on **2024-06-25**</sup>

#### โœจ Features

- **misc**: Add FileTypeIcon.

#### ๐Ÿ› Bug Fixes

- **misc**: Fix dir name, Fix type, hydration mismatch in grid background.

#### ๐Ÿ’„ Styles

- **misc**: Fix variant in MaterialFileTypeIcon, Increase gaps between ChatItem.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's improved

* **misc**: Add FileTypeIcon ([e43086f](e43086f))

#### What's fixed

* **misc**: Fix dir name ([d91dc53](d91dc53))
* **misc**: Fix type ([6b289c9](6b289c9))
* **misc**: Hydration mismatch in grid background, closes [lobehub#171](https://github.com/bentwnghk/lobe-ui/issues/171) ([bbe43c4](bbe43c4))

#### Styles

* **misc**: Fix variant in MaterialFileTypeIcon ([1066729](1066729))
* **misc**: Increase gaps between ChatItem, closes [lobehub#170](https://github.com/bentwnghk/lobe-ui/issues/170) ([dd487de](dd487de))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvinxx arvinxx arvinxx left review comments

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@phuctm97 @lobehubbot @arvinxx @canisminor1990