Swift-ier Code #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shnhrrsn
commented
Oct 27, 2015
shnhrrsn
commented
- Now taking advantage of Swift 2 features like guard
- Removed most internal implicit optionals as they were prone to crashes
- Removed all external implicit optionals since XMLNullElement was already taking care of that
- Reworked init’s to drop the need for initXMLParser
- Removed redundant private/public properties where possible
- Restored description overrides
- Minor performance improvement by making the NSRegularExpression object a class constant instead of creating everytime parser:foundCharacters: is called
* Now taking advantage of Swift 2 features like guard * Removed most internal implicit optionals as they were prone to crashes * Removed all external implicit optionals since XMLNullElement was already taking care of that * Reworked init’s to drop the need for initXMLParser * Removed redundant private/public properties where possible * Restored description overrides * Minor performance improvement by making the NSRegularExpression object a class constant instead of creating everytime parser:foundCharacters: is called
|
This has now been updated for Swift 3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.