Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hidden stories still notify about comments #947

Open
pushcx opened this issue Nov 20, 2020 · 2 comments
Open

Hidden stories still notify about comments #947

pushcx opened this issue Nov 20, 2020 · 2 comments

Comments

@pushcx
Copy link
Member

pushcx commented Nov 20, 2020

The replying_comments view needs to be updated to ignore replies if the user has hidden the story.

Comment#deliver_mention_notifications needs to ignore replies if the receiver has hidden the story.

Comment#deliver_reply_notifications needs to ignore replies if the receiver has hidden the story. Maybe this is best implemented in users_following_thread but I haven't audited all functions that call it.

@Jaskaran2
Copy link

Hi is this issue still up for grabs??

@pushcx
Copy link
Member Author

pushcx commented Mar 12, 2023

Yup. Issues tagged 'good first issue' are pretty much always ready to be picked up! We don't assign issues and I try to only rarely (and explicitly) claim issues myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants