-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash in sandboxed chrome app. #68
Comments
it works for me, isn't the next code enough for sandboxed chrome app? if (window.chrome && window.chrome.runtime) {
return;
}
// Initialize localStorage and create a variable to use throughout the code.
var localStorage = window.localStorage; |
sorry, you're right. it was a bug in my chrome app building script |
Closed without fix? O really? |
@xquezme Sorry, I misread the comments and thought things were working. Sometimes I miss context from reading GitHub emails. That said, I thought https://github.com/mozilla/localForage/blob/master/src/drivers/localstorage.js#L10 fixed this already? |
Either way, I'll push a fix, as I think I'd prefer the try/catch over the @xquezme In the future, if you'd like to submit a pull request directly (given that you had the code ready in this issue) I would happily accept it. I'm usually faster to merge pull requests than anything else. |
Just wrap
into
The text was updated successfully, but these errors were encountered: