Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Empty) map displays in directory channel #229

Closed
msayoung opened this issue Sep 13, 2022 · 1 comment · Fixed by localgovdrupal/localgov_base#296 or #239
Closed

(Empty) map displays in directory channel #229

msayoung opened this issue Sep 13, 2022 · 1 comment · Fixed by localgovdrupal/localgov_base#296 or #239
Assignees
Labels
1 bug Something isn't working

Comments

@msayoung
Copy link
Member

msayoung commented Sep 13, 2022

Steps to reproduce:

  1. add a directory channel
  2. add promo pages
  3. visit channel
  4. see an empty map
@msayoung msayoung added the bug Something isn't working label Sep 13, 2022
@finnlewis finnlewis added the 1 label Sep 28, 2022
@finnlewis finnlewis assigned ekes and unassigned stephen-cox Sep 28, 2022
@ekes
Copy link
Member

ekes commented Oct 7, 2022

Argh.

So the map gets hidden if there are no results. But there are results they just don't have a location. But we can't filter on them having a location, because that's not indexed by Search API (guess we'd need Adnan's patch to do that, and it's not consistent for all versions of MySQL).

The features are put into the attachment of the render array. So you can't hide the map based on if they are there, because it's not available in the render. There are alter hooks but they still put a map element in.

Patching the module is the easiest, but this is such an edge case I can't see the patch going in.

Adding something to the index that can be filtered on seems one option.
Somehow getting some data to the map that it has features so it can be hidden in the theme seems to be the other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 bug Something isn't working
Projects
Status: Done sprint 11
4 participants