-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drupal 10 support #65
Comments
Looks pretty straightforward, except the javascript, just running through that. |
Also needed https://git.drupalcode.org/project/geo_entity/-/blob/1.0.x/modules/geo_entity_address/js/autocomplete.js#L151 changed. This was the last required change for 10.x other improvements, not required for 10.x, could be moved to this module; or migrate to geo_entity. |
Looks like this is going to be the first module to have a major release with D10 only support. It's not possible to install the Geocoder 4 along with the drupal/core-recommends 9.x package as specify different versions of Guzzle: https://www.drupal.org/project/geocoder/issues/3283651. The current version 1 will need to require Geocoder 3 and a new version 2 will require Geocoder 4. |
As this is now Geo_entity, I suggest we make the profile for Drupal 10 use that instead. Does raise the question about what happens to modules that use lcoalgov_geo, I assume they will need a new release to support the new geo entity, and a migration for the data? |
Closing as we have D10 support working |
Issue to track any changes needed to support Drupal 10
The text was updated successfully, but these errors were encountered: