Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drupal 10 support #65

Closed
stephen-cox opened this issue Dec 16, 2022 · 6 comments
Closed

Drupal 10 support #65

stephen-cox opened this issue Dec 16, 2022 · 6 comments
Assignees

Comments

@stephen-cox
Copy link
Member

Issue to track any changes needed to support Drupal 10

@stephen-cox stephen-cox self-assigned this Dec 16, 2022
@ekes
Copy link
Member

ekes commented Feb 6, 2023

Looks pretty straightforward, except the javascript, just running through that.

@ekes
Copy link
Member

ekes commented Feb 6, 2023

@ekes
Copy link
Member

ekes commented Feb 26, 2023

Also needed https://git.drupalcode.org/project/geo_entity/-/blob/1.0.x/modules/geo_entity_address/js/autocomplete.js#L151 changed. This was the last required change for 10.x other improvements, not required for 10.x, could be moved to this module; or migrate to geo_entity.

@stephen-cox
Copy link
Member Author

Looks like this is going to be the first module to have a major release with D10 only support.

It's not possible to install the Geocoder 4 along with the drupal/core-recommends 9.x package as specify different versions of Guzzle: https://www.drupal.org/project/geocoder/issues/3283651.

The current version 1 will need to require Geocoder 3 and a new version 2 will require Geocoder 4.

@andybroomfield
Copy link
Contributor

As this is now Geo_entity, I suggest we make the profile for Drupal 10 use that instead. Does raise the question about what happens to modules that use lcoalgov_geo, I assume they will need a new release to support the new geo entity, and a migration for the data?

@stephen-cox
Copy link
Member Author

Closing as we have D10 support working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants