Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor LocalGov Drupal to use https://www.drupal.org/project/geo_entity #74

Closed
finnlewis opened this issue Mar 2, 2023 · 5 comments
Closed
Assignees

Comments

@finnlewis
Copy link
Member

finnlewis commented Mar 2, 2023

We now have https://www.drupal.org/project/geo_entity

It would be good to refactor LocalGov Drupal to use the d.o module.

We would need to write an update hook to migrate all existing entities.

  • migrate all localgov_geo entities to geo_entity entities
  • update all entity reference fields
  • add docs to advise switching geocode to OS places

We should really try to do this sooner rather than later. The longer we leave it the more gnarly it gets. Technical debt warning!

@ekes
Copy link
Member

ekes commented May 28, 2023

@ekes
Copy link
Member

ekes commented May 28, 2023

Requires test.

Might require also copying over view and form modes.

@ekes
Copy link
Member

ekes commented May 29, 2023

Might require also copying over view and form modes.

Doing this seems somewhat more involved because of changing from geofield_map to leaflet. Which is the desired change, so the defaults work. It would be if additional fields have been configured, or order. We could try and recreate some of this. But it might be easier for customized sites to update the fields themselves?

@finnlewis
Copy link
Member Author

finnlewis commented Jul 3, 2023

@ekes thinks there are a couple more display modes / entity reference fields to upgrade / fix.

To test:

  • Install the 2.x branch on Drupal 9.
  • Enable the localgov_demo module.
  • Run drush updb. This enables the module.
  • Then upgrade to Drupal 10.
  • The empty module will then get hook_updates to run and can run in Drupal 10.
  • Hopefully the geo entites will ahve been migrated to the new geo_entity.

Blocker for LGD 3.x alpha release? Yes!

  • we want fresh installs to use this by default.
  • the localgov_demo content will need to be updated.
  • Stephen: what happens if someone fails to install the 9.x module?
  • Ekes: all hook_updates will need to be run.

@finnlewis finnlewis self-assigned this Jul 3, 2023
@ekes
Copy link
Member

ekes commented Jul 24, 2023

#77

@ekes ekes closed this as completed Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants