Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directories submodule install order #31

Open
ekes opened this issue Jul 31, 2023 · 0 comments
Open

Directories submodule install order #31

ekes opened this issue Jul 31, 2023 · 0 comments

Comments

@ekes
Copy link
Member

ekes commented Jul 31, 2023

I don't know if this is desired; but it's quite possible for people to enable one of the directories submodule content types after enabling the directories multilingual submodule. They then won't get the field translation updates or config from the multilingual module.

In LocalGov we do have a pattern that includes updates no matter which order the modules that are enabled:-

The install hook calls the method https://github.com/localgovdrupal/localgov_directories/blob/0d8cc0e940193c68f1fed3bca9e6ea6025f0ce7e/localgov_directories.install#L25
But also the modules_installed hook https://github.com/localgovdrupal/localgov_directories/blob/0d8cc0e940193c68f1fed3bca9e6ea6025f0ce7e/localgov_directories.module#L89 checking for the relevant dependency module. This hook also triggers a rescan of the appropriate optional config too https://github.com/localgovdrupal/localgov_directories/blob/0d8cc0e940193c68f1fed3bca9e6ea6025f0ce7e/localgov_directories.module#L86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant