Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow editors to choose image style and layout for featured teaser and media and text #57

Open
msayoung opened this issue Jun 29, 2022 · 8 comments
Assignees
Labels
2 enhancement New feature or request

Comments

@msayoung
Copy link
Member

msayoung commented Jun 29, 2022

Featured teaser image

  • Add field to choose between teaser or card layout (teaser default)
  • Add image style options (square, 4:3, 3:2, 7:3)

Media with teaser image

  • Add image style options (square, 4:3, 3:2, 7:3)
@andybroomfield
Copy link
Contributor

Would this also apply to the media and text paragraph (50 / 50) as thats been flagged up as something we would like to change. Is there a module for this or does it require custom fields and preprocessing?

@msayoung
Copy link
Member Author

Hi @andybroomfield

At present we thought to add a field that allowed people to choose from 4 (?) image styles for both the "Featured teaser" and "Media and text" paragraph. I haven't thought through how we'll actually render the different styles, but maybe @markconroy has.

Additionally we thought to add an option on the "Featured teaser" to choose between a vertical "card" layout and horizontal "teaser" layout. Although I realise card should be the default not teaser - will amend the above.

As people can change the position of the image already on the "Media and text" we didn't think layout options were needed.

What were you hoping to do with the Media and image paragraph? Maybe we can build it in at the same time.

@andybroomfield
Copy link
Contributor

So currently we have take the crop off and editor crop the images in canva. But it would be nice to use the image styles that include pre cropped versions, assuming it is the same tecnique being applied for the above paragraph types.

@finnlewis
Copy link
Member

finnlewis commented Jul 6, 2022

Leaving this with @markconroy and @msayoung to discuss and bring a proposal or pull request if needed.

@finnlewis finnlewis added the enhancement New feature or request label Jul 6, 2022
@finnlewis finnlewis added the 2 label Jul 20, 2022
@msayoung msayoung removed their assignment Sep 6, 2022
@finnlewis
Copy link
Member

Bumping this for consideration for sprint 10... thoughts?

@markconroy
Copy link
Member

Good idea. Let's get it worked on.

@andybroomfield
Copy link
Contributor

I think @markconroy may have the answer already. Could we use this technique?

https://www.annertech.com/blog/allow-editors-choose-image-style-drupal-image-fields

@markconroy
Copy link
Member

Good old me, always one step ahead of myself, but not remembering so!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 enhancement New feature or request
Projects
Status: Sprint 13/14 backlog
Development

No branches or pull requests

4 participants