Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geolocation google maps api should be optional? #7

Open
andybroomfield opened this issue Sep 2, 2020 · 4 comments
Open

Geolocation google maps api should be optional? #7

andybroomfield opened this issue Sep 2, 2020 · 4 comments
Labels
question Further information is requested

Comments

@andybroomfield
Copy link
Contributor

Trying to enable the localgov_services_landing page in BHCC site installs quite a few dependencies based on localgov_paragraphs:

LocalGovDrupal Paragraphs, Telephone, Entity Usage, Geolocation - Google Maps API, Office Hours, Paragraphs Library, LocalGovDrupal Media, LocalGovDrupal Topics, LocalGov Services: Navigation, Localgov Page Components, Entity Browser IEF, Inline Entity Form modules to install LocalGov Services: Landing page

Since BHCC will not be using Google Maps, is there a reason that has to be enabled?

  • core.entity_form_display.paragraph.localgov_contact.default.yml contains config for Google maps on the form
  • core.entity_view_display.paragraph.localgov_contact.default.yml contains config for Google maps to display.

Ideally, these should be optional for those that don't use Google maps, becoming avalible when the Google maps plugin gets installed. This allows BHCC to swap out this for our Esri / OSM solution.

@Adnan-cds
Copy link
Contributor

Hi Andy,
Yes, Open Street Map is the default solution for mapping in LocalGov. Because the Contact Paragraph has been copied into LocalGov more or less unchanged, it is still stuck in Google maps which is how we built it here in Croydon. We will have to swap Google maps with OSM in Contact Paragraph as part of this ticket.

FAO @andybroomfield

@andybroomfield
Copy link
Contributor Author

andybroomfield commented Sep 2, 2020

Thanks @Adnan-cds
I think it will be the case that some councils will use Google maps, and others their own. I still see ours as being different as we tend to use Openlayers with a push to use Esri, rather than Leaflet which has better Drupal support. It comes down to each council site preferences hence my question on if this should be required or in optional.

@ekes
Copy link
Member

ekes commented Sep 2, 2020

That was the intention for building the geo module. The Googlemaps modules are inflexible in the sense that they can't be swapped and plugged. While the geocoder, geofield, leaflet combination are more complicated to configure UI wise they leave the opportunity that the backends (and maps) can then be swapped without further complexity. My assumption was always that the googlemap paragraph type would be swapped for the geo entity.

OH! Addition: It's also not the expectation that people will use OSM Nominatim for Geocoding in production, it's way too clunky in search and often missing data in the UK, but it is the easiest to package as an example as it doesn't require an API key. It really should be swapped for something with more free search, and data, in actual production.

@andybroomfield andybroomfield added this to To do in Alpha Sprint 9 via automation Sep 8, 2020
@finnlewis finnlewis removed this from To do in Alpha Sprint 9 Sep 23, 2020
@finnlewis finnlewis added this to To do in Alpha Sprint 10 via automation Sep 23, 2020
@stephen-cox
Copy link
Member

I've created a ticket to move the contact paragraph type to use the LocalGov Geo entity #10. This should resolve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
Development

No branches or pull requests

4 participants