Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove symfony/console #121

Merged
merged 3 commits into from Dec 9, 2018
Merged

Fix: Remove symfony/console #121

merged 3 commits into from Dec 9, 2018

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Dec 8, 2018

This PR

  • removes symfony/console
  • fixes issues detected by static analysis
  • casts indent size to string before passing it to NormalizeCommand in test

💁‍♂️ Not sure why I added it in the first place, to be honest.

@localheinz localheinz added the bug label Dec 8, 2018
@localheinz localheinz self-assigned this Dec 8, 2018
@localheinz localheinz changed the base branch from master to 1.0 December 8, 2018 23:09
@codecov
Copy link

codecov bot commented Dec 9, 2018

Codecov Report

Merging #121 into 1.0 will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##                1.0     #121   +/-   ##
=========================================
  Coverage     57.05%   57.05%           
  Complexity       35       35           
=========================================
  Files             2        2           
  Lines           170      170           
=========================================
  Hits             97       97           
  Misses           73       73
Impacted Files Coverage Δ Complexity Δ
src/Command/NormalizeCommand.php 54.65% <100%> (ø) 32 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3d4fa5...920c0fe. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 9, 2018

Codecov Report

Merging #121 into 1.0 will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##                1.0     #121   +/-   ##
=========================================
  Coverage     57.05%   57.05%           
  Complexity       35       35           
=========================================
  Files             2        2           
  Lines           170      170           
=========================================
  Hits             97       97           
  Misses           73       73
Impacted Files Coverage Δ Complexity Δ
src/Command/NormalizeCommand.php 54.65% <100%> (ø) 32 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3d4fa5...920c0fe. Read the comment docs.

@localheinz localheinz merged commit 119083a into 1.0 Dec 9, 2018
@localheinz localheinz deleted the fix/symfony branch December 9, 2018 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant